Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case for #5626 #8204

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Test case for #5626 #8204

merged 1 commit into from
Jul 4, 2018

Conversation

genotrance
Copy link
Contributor

No description provided.

@Araq
Copy link
Member

Araq commented Jul 4, 2018

This only tests that the snippet compiles! @Varriount Don't be as merge happy, please. ;-)

@genotrance
Copy link
Contributor Author

I've put in a request to revert. However, the test should have been run since all threading test cases should get run by default per this code:

# ------------------------- threading tests -----------------------------------
proc threadTests(r: var TResults, cat: Category, options: string) =
template test(filename: untyped) =
testSpec r, makeTest(filename, options, cat, actionRun)
testSpec r, makeTest(filename, options & " -d:release", cat, actionRun)
testSpec r, makeTest(filename, options & " --tlsEmulation:on", cat, actionRun)
for t in os.walkFiles("tests/threads/t*.nim"):
test(t)

Araq pushed a commit that referenced this pull request Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants