[superseded] partially address issue #8217 by running user config.nims if possible #8233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
force-pushed
the
pr_config_nims
branch
from
e98c340 to
054aae9
Compare
timotheecour
force-pushed
the
pr_config_nims
branch
from
054aae9 to
df13159
Compare
Araq
reviewed
Jul 16, 2018
| @@ -581,6 +581,7 @@ proc processCmdLine*(pass: TCmdLinePass, cmd: string; conf: ConfigRef) = | |||
| conf.projectName = a | |||
| # if processArgument(pass, p, argsCount): break | |||
|
|
|||
| # TODO: refactor with nimconf.nim to avoid duplicating complex logic | |||
There was a problem hiding this comment.
Good catch. But I cannot merge a PR that makes things worse, then nimsuggest disagrees with nim's way of reading the configuration.
There was a problem hiding this comment.
ok, pending refactoring via OOP here #8682 (comment)
timotheecour
changed the title
timotheecour
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @Araq
this PR runs user's config.nims if it exists and another nims hasn't also ran before, allowing to apply user configuration globally via nimscript instead of the more limited language nim.cfg
ideally, we would instead do the following:
but that logic fails because call(EDIT: FIXED)runNimScriptmultiple times in errors with:???(0, 0) Error: internal error: n is not nil(see #8235)
TODO in future PR: apply that same logic to
nimsuggest.nim(and refactor to remove code duplication between nimsuggest.nim and nim.nim)