Yet another change to evalOnce #8578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the checks in order not to break the bootstrap and possibly cover more cases that were previously ignored. Fixes nim-lang#8577
|
super cool, seems to work after i patched it, thanks! btw here's another bug with mapIt, but less serious since workaround for it are easier: #8580 |
|
another corner case, but less serious block:
# BUG: Error: invalid type: 'openarray[int]' for let
let foo2 = openArray[int]([1,2]).mapIt(it)
block:
# ok
let foo2 = openArray[int]([1,2]).map(proc(a:int):auto=a*10)
echo foo2 |
timotheecour
requested changes
Aug 9, 2018
There was a problem hiding this comment.
please do not pull, I have a better fix in progress => #8584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the checks in order not to break the bootstrap and possibly
cover more cases that were previously ignored.
Fixes #8577
CC @timotheecour