Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC for symbol alias for https://github.com/nim-lang/Nim/pull/11992 #235

Merged
merged 3 commits into from
Jun 18, 2020

Conversation

timotheecour
Copy link
Member

No description provided.

composable iterators, which allows define lazy functional programming primitives (eager `toSeq` and lazy `map/filter/join` etc; which can have speed benefit compared to `sequtils`); the resulting code is quite nice and compact, see `tlambda_iterators.nim` which uses library `lambdaIter` that builds on top of `lambda`; it allows defining primitives that work regardless we're passing a value (`@[1,2,3]`) or a lazy iterate (eg `iota(3)`)

## Motivation 5: this fixes or closes a lot of issues
see a sample here: https://github.com/nim-lang/Nim/pull/11992
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's logically impossible that a feature addition fixes existing bugs. What do you really mean? That the patch also happens to fix existing compiler bugs? That the new feature allows for new workarounds?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the distinction between bugs and feature requests is by definition a gray area, and some github issues are reducible to feature requests so there's no contradiction.
Anything I listed in nim-lang/Nim#11992 as closable should be closable with that PR (because it'd make no sense keeping the issue opened past that); but of course we can debate that list 1 by 1.

and IIRC the PR has tests for all issues I intend to close with this PR.

@timotheecour timotheecour merged commit d06ed95 into nim-lang:master Jun 18, 2020
@timotheecour timotheecour deleted the pr_rfc_alias branch June 18, 2020 08:42
@timotheecour
Copy link
Member Author

merging but happy to address more comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants