Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Pollard's p-1 example #138

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Sep 24, 2023

This PR adds an example of factorization using Pollard's p-1 algorithm. This is related to #70 and similar to #129.

@konsumlamm
Copy link
Contributor

Given that we already have an example for Pollard's rho algorithm, which looks pretty similar, and that Pollard's p-1 algorithm only works for certain numbers, I'm not sure we should add this.

@vil02
Copy link
Contributor Author

vil02 commented Nov 29, 2023

Both of these algorithms work for some class of the numbers. I am not sure what is the relation between these classes - @konsumlamm do you know?

Eventually these are two different algorithms. I think it will not hurt to have both as examples.

@dlesnoff
Copy link
Contributor

dlesnoff commented Dec 1, 2023

I am okay with adding this example. It adds a little burden maintaining those examples, especially when the API is not perfectly stable, or the Nim version changes. Let's close #70 after this PR and focus on the library.

@narimiran narimiran merged commit b99fb99 into nim-lang:master Dec 1, 2023
4 checks passed
@vil02 vil02 deleted the add_pollards_p_minus_1 branch December 1, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants