CI JS

[juancarlospaco]

• fusion CI should run tests and docs for js #63 (comment)

[timotheecour]

because theres stuff with broken style on Nim main repo on /lib/js/jsffi.nim and /lib/std/private/*.nim.

I see, you're hitting nim-lang/Nim#10201

theres stuff with broken style on Nim main repo

=> timotheecour/Nim#64 (comment)

[juancarlospaco]

Can not reproduce, also works on the CI.

[timotheecour]

@juancarlospaco
as i predicted in #64 (comment), passing explicitly -d:js is incorrect.

reduced case for the error i had in #64 (comment) with nimble docs:

echo "discard" > z03.nim
XDG_CONFIG_HOME= nim doc -b:js -d:js z03.nim

/Users/timothee/git_clone/nim/Nim_devel/lib/system/jssys.nim(54, 1) Error: redefinition of 'getCurrentException'; previous declaration here: /Users/timothee/git_clone/nim/Nim_devel/lib/system.nim(2386, 8)

devel a0134671eeed3cfac1e9035568cbdec41825da8d: error
1.4.0: no error (might explain why you didn't get an error)

basically, in this case, it causes issues because of interaction of -d:js and nimscript (but there could be other bad consequences for -d:js being passed explicitly)

note

I'm not sure why CI doesn't show an error here (maybe another bug that hides this bug; we should investigate whether fusion CI actually also runs on latest nim devel instead of a cached version or a nightly), but the fix here is:

exec "nim c -r -d:fusionDocJs src/fusion/docutils " & srcDir & " -d:js -d:fusionDocJs"
=>
exec "nim c -r -d:fusionDocJs src/fusion/docutils " & srcDir

[timotheecour]

i don't quite understand the changes in tests/tmatching.nim ; didn't CI pass before your PR ?

also links like https://github.com/nim-lang/fusion/pull/64/checks?check_run_id=1640671490#step:8:251 expire (CI keeps those for limited time only) so these should point to somewhere else, for example:

• copy paste the relevant part of logs into a conversation comment in this PR (showing the source)
• link to those instead (would look like: CI JS #64 (comment))

[juancarlospaco]

I can revert tests/tmatching.nim but CI wont be green, you literally passed the code to workaround it. 🤷

[timotheecour]

but CI wont be green

but I'm trying to understand why is CI green currently (before your PR) ?

[juancarlospaco]

You already seen the test that wont pass with specific versions, etc.
I am just trying to make it more strict, cover JS too, even tried to enforce style.
:)

If you think this makes CI worse, feel free to close it.

[timotheecour]

feel free to close it.

your PR is good, I'm just trying to understand that specific point; I'll do some experiments in #66 to understand what's going on with tests/tmatching.nim

[timotheecour]

indeed, I was right to be suspicious about the changes to tests/tmatching.nim; see #68 and #67; they shouldn't be needed
(some changes that fix style are ok though)

EDIT: ok, #67 was merged, let's try removing the changes to tests/tmatching.nim (minus style fix ones if you want)

[juancarlospaco]

@timotheecour ping. Also nim-lang/Nim#16630 (comment)