use nimPreviewSlimSystem everywhere, workarounds for 2.0 compiler #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metagn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler codebase has
nimPreviewSlimSystemon, do the same here and without conditions since it's unlikely we will have to compile nif with a < 2.0 compiler. It's easy to make conditional if we do though.Workarounds for the csources_v2 (2.0) compiler are also added for bootstrapping Nim. These are for the lack of non-var destructors and a template resolution bug with dot fields in
packedtrees.ensureMovealso does not exist on 2.0 but this can also be fixed by makingensureMovea no-op on older versions in the Nim repo standard library for just bootstrapping.Tested at nim-lang/Nim#24262.