Requiring a specific git hash fails

[bluenote10]

A statement like this

Requires: "nim >= 0.10.3, nim-stringinterpolation#e0746e3"

fails, because the hash will be interpreted as the branch variable at this point (running git fetch origin --depth 1 e0746e3e manually produces fatal: Couldn't find remote ref e0746e3e). On the other hand:

Requires: "nim >= 0.10.3, nim-stringinterpolation#master"

also fails, probably in the checkout command.

Probably the syntax for Requires should allow to provide both the branch and the hash.

[dom96]

I don't think Nimble needs to distinguish between commit hashes and branch names.

[bluenote10]

Yes, you are right. The hash determines the branch, so it is definitely better not having to specify them both.

[timotheecour]

minor nit: can't it lead to ambiguities in the rare case a hash (short form) matches a branch name?

[dom96]

@timotheecour if it's good enough for Git...