before install not called when installing from nim-lang/packages

[silversquirl]

When running nimble install within my package directory, before install blocks are executed as normal. When installing from nim-lang/packages with nimble install mypackage, they are not.

I'm not sure how to gather more information about this, as I can't choose an alternate source to install from, as far as I can tell.

[silversquirl]

Installing directly from Git using nimble install https://foo/bar.git works as expected.

[silversquirl]

Ah, that's wrong. I was running the command from within my project directory, which made it succeed.

[silversquirl]

I think I've tracked down the issue.

When Nimble starts, it first parses command line arguments, then runs the doAction proc on the resulting Options object. One of the first things doAction does is to run execHook, which then looks for a .nimble file in the current directory. If it can't find one, it exits without doing anything. This is why it works as expected when run in my project directory, but not when running elsewhere.

The problem is that fixing this appears like it would require a rather major refactor of Nimble, so I think it's better for me to work around this issue by creating a separate task which I can run every so often to update my wrapper, rather than doing it directly before install.

[dom96]

This is still an issue though. Doesn't matter how difficult it is to fix.

[genotrance]

Unfortunately this is affecting nimssl and nimbass as well since they actually generate the wrappers using nimgen before installing to the ~/.nimble directory.

I've updated my README as well like khogeland's commit above but a fix would be much cooler.

[dom96]

@genotrance cool library, I'll make this a high priority.

[dom96]

This was fixed it seems :)

[dom96]

Reopening as this wasn't fixed properly.

[dom96]

So just to clarify, this was fixed, but the hook is run too quickly (before dependencies are installed), so you get issues like this when installing packages that depend on 'nimgen' (as an example):

[genotrance]

Yes exactly - the latest commits fixes this exact problem.

[dom96]

This should now be fixed. I've added a test for it in db222bb as well.

The above commit also implements before develop.