Publish binaries of nimble #1068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zah
reviewed
Feb 13, 2023
| @@ -0,0 +1,90 @@ | |||
| on: | |||
There was a problem hiding this comment.
This should probably be:
on:
push:
tags:
- 'v*' # "v1.2.3"
This way, we'll be triggering the build only on tagged releases.
|
|
||
| - uses: ncipollo/release-action@v1 | ||
| with: | ||
| name: Latest Langserver Binaries |
There was a problem hiding this comment.
Accidental reference to the Langserver
There was a problem hiding this comment.
Will be fixed. I did this change first in langserver repo.
yyoncho
force-pushed
the
binaries
branch
4 times, most recently
from
d4dc667 to
4e75881
Compare
yyoncho
added a commit
to yyoncho/nimble
that referenced
this pull request
Mar 15, 2023
- Another attempt after nim-lang#1068. This PR uses the images that are used by https://github.com/nim-lang/nightlies
yyoncho
added a commit
to yyoncho/nimble
that referenced
this pull request
Mar 15, 2023
- Another attempt after nim-lang#1068. This PR uses the images that are used by https://github.com/nim-lang/nightlies in order to build proper binary
zah
pushed a commit
that referenced
this pull request
Apr 10, 2023
- Another attempt after #1068. This PR uses the images that are used by https://github.com/nim-lang/nightlies in order to build proper binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.