Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force line endings when cloning #1072

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Force line endings when cloning #1072

merged 1 commit into from
Feb 20, 2023

Conversation

yyoncho
Copy link
Contributor

@yyoncho yyoncho commented Feb 20, 2023

  • If we don't force them then depending on the target os the checksum might
    fail.

- If we don't force them then depending on the target os the checksum might
fail.
@Araq
Copy link
Member

Araq commented Feb 20, 2023

Shouldn't instead the checksum be made oblivious to the used line endings? But I don't what is better here, just pointing out an alternative.

@yyoncho
Copy link
Contributor Author

yyoncho commented Feb 20, 2023

There is already core.autocrlf=false passed as a param so it seems like the decision to go in that direction has already been made.

@Araq Araq merged commit 47531a6 into nim-lang:master Feb 20, 2023
@Araq
Copy link
Member

Araq commented Feb 20, 2023

Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants