Implement nimble shellenv and nimble shell #1081
Conversation
Added commands `nimble shell` and `nimble shellenv` to allow using shell in the scope of the project
src/nimble.nim
Outdated
| let fullInfo = pkg.toFullInfo(options) | ||
| for bin, _ in fullInfo.bin: | ||
| let folder = fullInfo.getOutputDir(bin).parentDir.quoteShell | ||
| result = fmt "{folder}{separator}{result}" |
There was a problem hiding this comment.
This algorithm is needlessly quadratic. You can construct the list of nimble PATH additions by regular appending and then concatenate it once with the original PATH variable.
There was a problem hiding this comment.
Fixed in the latest commit.
src/nimble.nim
Outdated
| if shell == "": shell = "powershell" | ||
| else: | ||
| var shell = getEnv("SHELL") | ||
| if shell == "": shell = "/bin/bash" |
There was a problem hiding this comment.
Launching /usr/bin/env bash would be more portable.
There was a problem hiding this comment.
Pushed a slightly different fix: I use bash and pass poUserPath. This approach leads to a bit simpler code(no need to track args)
src/nimble.nim
Outdated
| var shell = getEnv("SHELL") | ||
| if shell == "": shell = "/bin/bash" | ||
|
|
||
| discard waitForExit startProcess(shell, options = {poParentStreams}) |
There was a problem hiding this comment.
On POSIX systems, using execve (or a similar function) would reduce the system memory usage here:
There was a problem hiding this comment.
I was under the assumption that poParentStreams will end up using that. I will check that out.
There was a problem hiding this comment.
I tracked the code and it indeed calls execve under the hood. That particular invocation: https://github.com/yyoncho/Nim/blob/optimize-nimble/lib/pure/osproc.nim#L1176
There was a problem hiding this comment.
No, you are seeing the classic fork/exec pattern.
No invocation of startProcess will be equivalent to execve because startProcess as an API returns the result of the launched process and the execution of the original program continues. The point of execve is to essentially terminate the execution of the current program by replacing its address space with the launched new process.
Added commands
nimble shellandnimble shellenvto allow using shell in thescope of the project