Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to allow skipping of the validation during nimble develop #1112

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

yyoncho
Copy link
Contributor

@yyoncho yyoncho commented Jun 20, 2023

No description provided.

@yyoncho
Copy link
Contributor Author

yyoncho commented Jun 26, 2023

@Araq the label didn't kick in after the rebase.

@Araq Araq merged commit 16fa227 into nim-lang:master Jun 26, 2023
@Araq
Copy link
Member

Araq commented Jun 26, 2023

The label has no attached automation, it only means that somebody can merge it once the CI is green as I have reviewed it already.

yyoncho added a commit to yyoncho/nimble that referenced this pull request Jun 28, 2023
Araq pushed a commit that referenced this pull request Jun 29, 2023
…ppens (#1117)

* Revert "Add flag to allow skipping of the validation during nimble develop (#1112)"

This reverts commit 16fa227.

* Validation breaks package version check

- when validation fails the PackageInfo ends up uninitialized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants