SAT Progress #1217
Merged
SAT Progress #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
May 1, 2024
Araq
reviewed
May 1, 2024
Araq
reviewed
May 1, 2024
Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
Araq
reviewed
May 2, 2024
Araq
reviewed
May 2, 2024
Araq
reviewed
May 2, 2024
| @@ -323,7 +323,8 @@ proc getSolvedPackages*(pkgVersionTable: Table[string, PackageVersions], output: | |||
| result.add solvedPkg | |||
|
|
|||
| proc getCacheDownloadDir*(url: string, ver: VersionRange, options: Options): string = | |||
| options.pkgCachePath / getDownloadDirName(url, ver, notSetSha1Hash) | |||
| return "" | |||
| # options.pkgCachePath / getDownloadDirName(url, ver, notSetSha1Hash) | |||
There was a problem hiding this comment.
It prevents packages being downloaded twice ("" makes it so it uses a temp directory). A test is failing when is set (SAT only oc). I disabled it so I can be sure it doesnt interfere with the main goal which is making existing functionality work with SAT, after that I will work on the failing test (spend a lot of time already trying to fix it, but decided to move on and fix SAT first)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most tests are green now