-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nimble test
keeps git status clean; prevents accidental checking in of binaries etc
#786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applaud your fight to keep git status
clean, I think your proposal in that issue you wrote has more merit.
@dom96 friendly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, alright, seems good. Can you rebase?
97e816a
to
97417f1
Compare
PTAL |
Yeah, dunno what's going on with the CI. I created iffy/install-nim#8 |
…(can be improved later) * simplify gitignore logic
97417f1
to
24e99f3
Compare
@dom96 PTAL, finally green |
thanks! |
nimble test
should keepgit status
cleangit rm tests/nimbleVersionDefine/src/nimbleVersionDefine
in this PR