Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package HolidAPI #2908

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Add package HolidAPI #2908

merged 2 commits into from
Jul 16, 2024

Conversation

nirokay
Copy link
Contributor

@nirokay nirokay commented Jul 16, 2024

This package is a collection of API wrappers to fetch holidays and do some code wizardry on them.

@nirokay
Copy link
Contributor Author

nirokay commented Jul 16, 2024

should I have added the "library" tag?

@narimiran
Copy link
Member

E: holidapi has an invalid method

Method should be "git", not "url".

narimiran
narimiran reviewed Jul 16, 2024
View reviewed changes
packages.json Outdated Show resolved Hide resolved
@nirokay
Copy link
Contributor Author

nirokay commented Jul 16, 2024

oh I am sorry, thank you :)

@narimiran narimiran merged commit a100778 into nim-lang:master Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narimiran narimiran narimiran left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nirokay @narimiran