Update npm package dependencies, in order to support the latest version of the Language Server Protocol #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent and the language server
…ter the version upgrade of vscode-languageclient
…as suggested by: https://code.visualstudio.com/api/references/extension-manifest#approved-badges Without this, 'nimble vsix' doesn't work
…n the 1.6.x series)
…nd for the fact that the `nim` package no longer provides the nimsuggest sources)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this pull request contains the same things as: saem/vscode-nim#134
I'm opening it here, because there was no reaction from Saem on this pull request for over a month.
I'm working on adding inlay hint support to nimsuggest and the Nim language server. Inlay hints are supported in the latest (3.17) version of the Language Server Protocol. But for this to work in VS code with this extension, the npm package vscode-languageclient needed to be updated, so this was done in this pull request. Updating the npm dependencies also resolves several known security vulnerabilities in the old versions of the packages that were used previously.
This pull request also includes fixes for compilation with Nim version 1.6.16 (the latest stable version in the 1.6.x series). There's also an addition to the compilation instructions in the README.md file - there's an extra step needed, before the package can be compiled, because the nimsuggest sources are required for compilation, however (as far as I know), they were dropped from the 'nim' nimble package.
There's also a new configuration option for tracing the communication between the VS code extension and the language server (and writing in the 'Output' window), when this extension is run in lsp mode.