f

nim-works · Nov 21, 2021 · 0c2babb · 0c2babb
1 parent ec0a814
commit 0c2babb
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 158 deletions.
diff --git a/doc/testament.rst b/doc/testament.rst
@@ -177,7 +177,7 @@ Example "template" **to edit** and write a Testament unittest:
     disabled: "32bit" # ...or architectures
     disabled: "i386"
     disabled: "azure" # ...or pipeline runners
-    disabled: true    # ...or can disable the test entirely
+
 
   """
   assert true

diff --git a/testament/specs.nim b/testament/specs.nim
@@ -104,6 +104,7 @@ type
                       # but don't rely on much precision
     inlineErrors*: seq[InlineError] # line information to error message
     debugInfo*: string # debug info to give more context
+    knownIssues*: seq[string] ## known issues to be fixed
 
 proc getCmd*(s: TSpec): string =
   if s.cmd.len == 0:
@@ -275,7 +276,7 @@ proc parseSpec*(filename: string): TSpec =
     case e.kind
     of cfgKeyValuePair:
       let key = e.key.normalize
-      const allowMultipleOccurences = ["disabled", "ccodecheck"]
+      const allowMultipleOccurences = ["disabled", "ccodecheck" , "knownissue"]
         ## list of flags that are correctly handled when passed multiple times
         ## (instead of being overwritten)
       if key notin allowMultipleOccurences:
@@ -385,7 +386,7 @@ proc parseSpec*(filename: string): TSpec =
         of "netbsd":
           when defined(netbsd): result.err = reDisabled
         else:
-          result.parseErrors.addLine "cannot interpret as a bool: ", e.value
+          result.parseErrors.addLine "cannot interpret as a bool or platform name: ", e.value
       of "cmd":
         if e.value.startsWith("nim "):
           result.cmd = compilerPrefix & e.value[3..^1]
@@ -408,6 +409,12 @@ proc parseSpec*(filename: string): TSpec =
       of "matrix":
         for v in e.value.split(';'):
           result.matrix.add(v.strip)
+      of "knownissue":
+        case e.value.normalize
+        of "n", "no", "false", "0": discard
+        else: 
+            result.knownIssues.add e.value
+            result.err = reDisabled
       else:
         result.parseErrors.addLine "invalid key for test spec: ", e.key
 

diff --git a/tests/bind/tdatabind.nim b/tests/bind/tdatabind.nim
diff --git a/tests/closure/texplicit_dummy_closure.nim b/tests/closure/texplicit_dummy_closure.nim
diff --git a/tests/lang/s01_basics/s05_data_types/t4_char.nim b/tests/lang/s01_basics/s05_data_types/t4_char.nim
diff --git a/tests/parallel/t5000.nim b/tests/parallel/t5000.nim
diff --git a/tests/proc/t17157.nim b/tests/proc/t17157.nim
@@ -1,6 +1,7 @@
 discard """
   errormsg: "'untyped' is only allowed in templates and macros or magic procs"
-  disabled: true
+  knownIssue: "https://github.com/nim-lang/Nim/issues/18113"
+  knownIssue: "https://github.com/nim-lang/Nim/issues/18124"
 """
 
 template something(op: proc (v: untyped): void): void =

diff --git a/tests/typerel/trectuple.nim b/tests/typerel/trectuple.nim
@@ -1,7 +1,7 @@
 discard """
   errormsg: "illegal recursion in type 'TNode'"
   line: 8
-  disabled: true
+
 """
 
 type

diff --git a/tests/typerel/trectype.nim b/tests/typerel/trectype.nim
@@ -1,6 +1,6 @@
 discard """
   errormsg: "internal error: cannot generate C type for: PA"
-  disabled: true
+
 """
 # Test recursive type descriptions
 # (mainly for the C code generator)

diff --git a/tests/types/tisop.nim b/tests/types/tisop.nim
@@ -1,5 +1,5 @@
 discard """
-  disabled: true
+
 """
 
 import typetraits