Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add debugAst(), debugType() and debugSym() procs back to astrepr #203

Closed
3 tasks done
haxscramper opened this issue Jan 25, 2022 · 1 comment · Fixed by #204
Closed
3 tasks done

add debugAst(), debugType() and debugSym() procs back to astrepr #203

haxscramper opened this issue Jan 25, 2022 · 1 comment · Fixed by #204
Assignees
@haxscramper
Labels
enhancement New feature or request

Comments

@haxscramper
Copy link
Collaborator

haxscramper commented Jan 25, 2022 •
edited
Loading

  • Add overload of the treeRepr that does not accept ConfigRef object
  • Allow passing nil conf to the treeRepr
  • Add helper procedures - debugAst(), debugType() and debugSym() with {.exportc.} annotations to be used in the debugging

#191 removed API a little too aggressively - the no-argument debug still needs to be present
@haxscramper haxscramper added the enhancement New feature or request label Jan 25, 2022
@haxscramper haxscramper self-assigned this Jan 25, 2022
@krux02
Copy link
Contributor

krux02 commented Jan 25, 2022

I didn't see that you took out debug entirely in the old PR. Github in being github was smart and decided that the files with the most changes are not important enough to be shown.

@haxscramper haxscramper mentioned this issue Jan 25, 2022
Merged
bors bot added a commit that referenced this issue Jan 25, 2022
@bors @haxscramper
Merge #204
b9ea9a1 
204: debug: add debug(), debugAst() etc. to astrepr r=haxscramper a=haxscramper

Closes #203 - adds missing
debug procedures to the `astrepr` module, returning the old API for
debugging.


Co-authored-by: haxscramper <haxscramper@gmail.com>
@bors bors bot closed this as completed in a8bdd49 Jan 25, 2022
@bors bors bot closed this as completed in #204 Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haxscramper haxscramper

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

debug: add debug(), debugAst() etc. to astrepr haxscramper/nimskull
2 participants
@krux02 @haxscramper