use improved range check of 128 for float64 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krux02
force-pushed
the
minor-range-check-improvement
branch
from
6a92fd6 to
4fa7bfb
Compare
alaviss
reviewed
Jan 16, 2022
krux02
force-pushed
the
minor-range-check-improvement
branch
from
4fa7bfb to
e7684e7
Compare
|
I had a giant comment and I think it totally got lost. :( Oh well, it can wait. |
krux02
force-pushed
the
minor-range-check-improvement
branch
3 times, most recently
from
a0dcc29 to
1236372
Compare
alaviss
reviewed
Jan 19, 2022
compiler/int128.nim
Outdated
| proc inInt128Range*(arg: float64): bool = | ||
| ## Simple range check. Of coures NaN is defined not to be in range. | ||
| lowerBoundF64 <= arg and arg < upperBoundF64 | ||
|
|
||
| proc toInt128*(arg: float64): Int128 = |
There was a problem hiding this comment.
I'd suggest adding some docs to describe this function behavior.
Suggested change
| proc toInt128*(arg: float64): Int128 = | |
| proc toInt128*(arg: float64): Int128 = | |
| ## Return an `Int128` representing the non-factional part of `arg`. | |
| ## | |
| ## Return the maximum or minimum `Int128` when `arg` cannot be represented. |
compiler/int128.nim
Outdated
| return Min | ||
| if upperBoundF64 <= arg: | ||
| return Max | ||
|
|
There was a problem hiding this comment.
I would have picked 0xDEADBEEF or something. But 0 is fine for me as well.
* Add a range check function to test if a float64 is in rage of the int128 type. * Use that range check function for semexpr.checkConvertible * `toInt128(arg: float64)` now has clamping behavior. * fixes nim-works#93 While this fixes the original issue mentioned above, it does not fix or implement the discussions in that issue. They need to be ported to their own issue. converting float64 to int128 is now clamping
krux02
force-pushed
the
minor-range-check-improvement
branch
from
1236372 to
1cc5367
Compare
|
checks have passed. you can take a look again for the merge. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int128type.semexpr.checkConvertibleWhile this fixes the original issue mentioned above, it does not fix or implement the discussions in that issue. They need to be ported to their own issue.