-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specification tests PR1 #28
Conversation
This is headed in a very good direction. The efforts put into organization up front and the detail focus is really coming through. Felt like I was learning the language as I read the tests, that's awesome! Keep going, you got this. |
Thanks. While writing this, I thought that it would be possible to deprecate There are some open questions wrt. to testing things like |
As per our earlier discussion (incrementally merging tests as I write them instead of waiting for some "final" state) I cleaned up things and update some small missing documentation bits. I also tried out the idea of building a manual from the tests - https://github.com/haxscramper/hack/blob/1d27d5515b48cd57500f75d9dfca1160aa2664a2/testing/nim/implementation_ideas/build_manual.nim ... I think it is possible to do, though nim rst renderer is ugly as hell, and it is hard to procedurally create rst AST that will simply be converted to the readable document. But that is a trivial thing to fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is absolutely fantastic
tests/lang/s01_basics/s08_user_defined_data_types/t02_plain_objects.nim
Outdated
Show resolved
Hide resolved
tests/lang/s01_basics/s08_user_defined_data_types/t02_plain_objects.nim
Outdated
Show resolved
Hide resolved
tests/lang/s01_basics/s08_user_defined_data_types/t02_plain_objects_fail2_requiresinit.nim
Outdated
Show resolved
Hide resolved
tests/lang/s01_basics/s08_user_defined_data_types/t03_inheritance.nim
Outdated
Show resolved
Hide resolved
tests/lang/s01_basics/s08_user_defined_data_types/t04_variant_objects.nim
Show resolved
Hide resolved
82e3c15
to
eb7eda7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last batch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Except for squash, I think this is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure this is not meant to be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part, except some empty files.
6a89996
to
6ff47e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Build succeeded: |
Full spec todo - #10