Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification tests PR1 #28

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

haxscramper
Copy link
Collaborator

@haxscramper haxscramper commented Oct 30, 2021

Full spec todo - #10

@saem
Copy link
Collaborator

saem commented Oct 30, 2021

This is headed in a very good direction. The efforts put into organization up front and the detail focus is really coming through.

Felt like I was learning the language as I read the tests, that's awesome! Keep going, you got this.

@haxscramper
Copy link
Collaborator Author

haxscramper commented Oct 30, 2021

Thanks. While writing this, I thought that it would be possible to deprecate manual.rst in favor of the auto-generated documentation that is built from this language spec. Most likely I will be pulling in some pieces of description from the manual and real documentation in the future.

There are some open questions wrt. to testing things like dynlib for example (though, I would be very interested in including compiler interactions in the tests as well. Like testing that --app:lib behaves properly, for example)

@haxscramper haxscramper marked this pull request as ready for review October 31, 2021 13:41
@haxscramper
Copy link
Collaborator Author

As per our earlier discussion (incrementally merging tests as I write them instead of waiting for some "final" state) I cleaned up things and update some small missing documentation bits.

I also tried out the idea of building a manual from the tests - https://github.com/haxscramper/hack/blob/1d27d5515b48cd57500f75d9dfca1160aa2664a2/testing/nim/implementation_ideas/build_manual.nim ... I think it is possible to do, though nim rst renderer is ugly as hell, and it is hard to procedurally create rst AST that will simply be converted to the readable document. But that is a trivial thing to fix.

Copy link
Collaborator

@saem saem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is absolutely fantastic

Copy link
Collaborator

@saem saem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last batch

Copy link
Collaborator

@saem saem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@saem
Copy link
Collaborator

saem commented Nov 1, 2021

Except for squash, I think this is done.

Copy link
Contributor

@alaviss alaviss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@alaviss alaviss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, except some empty files.

@haxscramper haxscramper reopened this Nov 3, 2021
Copy link
Contributor

@alaviss alaviss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 3, 2021

Build succeeded:

@bors bors bot merged commit 21680c1 into nim-works:devel Nov 3, 2021
@haxscramper haxscramper changed the title Language spec tests Specification tests PR1 Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants