Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip "failing known issue" in CI post-failing #457

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Skip "failing known issue" in CI post-failing #457

merged 1 commit into from
Nov 4, 2022
+117 −57

Conversation

haxscramper
Copy link
Collaborator

  • Clean up implementation of the backend reporting: pass around proper report object that we already have instead of taking it apart into half a dozen string arguments that need to be pieced back into a JSON object anyway.
  • Add information about known issues to the testament JSON cache so they can be used in later PR for tracking known issues that no longer fail
  • Skip failing issues in the CI post-processing in order to reduce visual clutter.

@haxscramper
Skip "failing known issue" in CI post-failing
cfa6b47 
- Clean  up implementation  of the  backend reporting:  pass around  proper
  report object that we already have instead of taking it apart into half a
  dozen string  arguments that need  to be pieced  back into a  JSON object
  anyway.
- Add information about known issues to the testament JSON cache so they
  can be used in later PR for tracking known issues that no longer fail
- Skip failing issues  in the CI post-processing in order  to reduce visual
  clutter.

Fixes nim-works#456
@haxscramper haxscramper force-pushed the dont-reprint-failing-known-issues branch from d599ca5 to cfa6b47 Compare November 3, 2022 12:47
alaviss
alaviss approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@alaviss alaviss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@haxscramper
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 4, 2022

Build succeeded:

@bors bors bot merged commit 57b3c17 into nim-works:devel Nov 4, 2022
@haxscramper haxscramper added test Add or improve tests enhancement New feature or request labels Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaviss alaviss alaviss approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request test Add or improve tests
Projects
None yet
Milestone
Test suite reorganization and cleanup
Development

Successfully merging this pull request may close these issues.
2 participants
@haxscramper @alaviss