Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Guidelines Update #97

Merged
merged 1 commit into from
Dec 27, 2021
Merged

Community Guidelines Update #97

merged 1 commit into from
Dec 27, 2021

Conversation

shayanhabibi
Copy link
Collaborator

@shayanhabibi shayanhabibi commented Dec 6, 2021

Ready to merge

@shayanhabibi shayanhabibi added the enhancement New feature or request label Dec 6, 2021
Copy link
Contributor

@Vindaar Vindaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the two small comments, I like it.

ETHOS.md Outdated Show resolved Hide resolved
ETHOS.md Outdated Show resolved Hide resolved
@shayanhabibi shayanhabibi force-pushed the shayanhabibi/codeofconduct branch from 27f6ad9 to 2d40706 Compare December 6, 2021 14:23
@saem
Copy link
Collaborator

saem commented Dec 6, 2021

Read through it all, looks good.

After release I want to revise the ethos bit by bit too really capture the concept of sustainability. How everything fits together to create a sustainable socio-technical system (people, practices, and technology).

alaviss
alaviss previously approved these changes Dec 6, 2021
Copy link
Contributor

@alaviss alaviss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We are setting up but here is the space: https://matrix.to/#/#nimworks:envs.net

@shayanhabibi shayanhabibi force-pushed the shayanhabibi/codeofconduct branch from 2d40706 to 9ee3efa Compare December 7, 2021 01:36
@saem
Copy link
Collaborator

saem commented Dec 7, 2021

Booyeah

@haxscramper
Copy link
Collaborator

I think it makes sense to explain a different matrix rooms - maybe not #offtopic and #general, but things like #language-development, or #ux-feedback #106

@shayanhabibi shayanhabibi force-pushed the shayanhabibi/codeofconduct branch from 9ee3efa to 46bd1ad Compare December 8, 2021 03:12
@haxscramper
Copy link
Collaborator

If we plan to add community moderation guidelines, I think they should also include instructions on how to manage GitHub - issues, PRs, labels and so on. Code reviews and associated things. Not only attitude/tone recommendations, but also a literal checklist of things to watch for, how to meaningfully express concerns about submitted code and so on.

This idea is based on the discussion from the discussion in #general

"The best thing you can do, as a knowledge community member, is to enable others to contribute. Small effort on your end could go a long way when it comes to helping others - there is no shortage of bright and motivated people who are willing contribute, but not everyone has time to figure out what needs to be done from scratch"

"good first issue" must come with an explanation of what should be done, not a blind "oh, that's easy"

When to assign tag, what to look for in code reviews
Which parts of the changed code must be examined with utmost scrutiny

@alaviss alaviss self-requested a review December 12, 2021 04:17
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@saem
Copy link
Collaborator

saem commented Dec 12, 2021

If we plan to add community moderation guidelines, I think they should also include instructions on how to manage GitHub - issues, PRs, labels and so on. Code reviews and associated things. Not only attitude/tone recommendations, but also a literal checklist of things to watch for, how to meaningfully express concerns about submitted code and so on.

I agree that these are extremely valuable things, though they are also situation specific and better suited in more specific docs rather than a general one like this.

So we should have those docs, but I don't think we can cram it all into one.

@haxscramper
Copy link
Collaborator

Yes, I moderation guidelines are of course separate from code of conduct

@haxscramper
Copy link
Collaborator

#125

@shayanhabibi shayanhabibi force-pushed the shayanhabibi/codeofconduct branch from d0e1d3b to 8118a80 Compare December 22, 2021 01:12
Copy link
Contributor

@alaviss alaviss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments for the CoC

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved

</details>

2. <details><summary>Contribution does not entitle me or anyone else to act in any way that is not conducive to making this a productive and enjoyable environment</summary><br />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. <details><summary>Contribution does not entitle me or anyone else to act in any way that is not conducive to making this a productive and enjoyable environment</summary><br />
2. <details><summary>Contribution does not entitle anyone to act in any way that is not conducive to making this a productive and enjoyable environment</summary><br />

Mostly a nit, I don't like how "me" is used here, it doesn't feel right, especially when we were using "we" earlier.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I almost suggested the same change, but the meaning is subtlety different or at least slightly more explicit of written as is.

The current style ensures that it's taken to mean as no "shield" (defense against restriction of action) is granted by way of contribution.

While if someone that has contributed could be entitled to a "sword" (offense ability to restrict others behavior).

The suggested change reads as too strong a shield.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I can't remember the intention behind writing this as it is, I do agree with Saem's interpretation. I prefer it this way or rephrased as:

"Contribution does not entitle we, nor anyone else, to act in any way that is not conducive to making this a productive and enjoyable environment"

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved

> *"People from different backgrounds are likely to have different interpretations of what words or behaviors are considered acceptable. It's somewhat ironic that in an attempt to draw a more diverse developer base, code of conduct moderation, if improperly conducted, could potentially alienate users from other countries who don't have the same social conditioning as those in North America [or other Western cultures]."*[^2]

1. The Code of Conduct can be enforced through a range of passive and active means. We recommend minimal use for first offenders but allow rapid escalation if required (depending on the severity of the breach).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "minimal use"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As according to the reasonable person principle; we have not yet discussed hierarchy of rule enforcement so I cannot determine this without input from everyone.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with it, gives room to grow.

@alaviss alaviss self-requested a review December 22, 2021 01:42
Copy link
Collaborator

@saem saem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things.

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved

</details>

2. <details><summary>Contribution does not entitle me or anyone else to act in any way that is not conducive to making this a productive and enjoyable environment</summary><br />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I almost suggested the same change, but the meaning is subtlety different or at least slightly more explicit of written as is.

The current style ensures that it's taken to mean as no "shield" (defense against restriction of action) is granted by way of contribution.

While if someone that has contributed could be entitled to a "sword" (offense ability to restrict others behavior).

The suggested change reads as too strong a shield.

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@shayanhabibi shayanhabibi force-pushed the shayanhabibi/codeofconduct branch from 8118a80 to 9e2fd40 Compare December 26, 2021 13:24
Copy link
Contributor

@alaviss alaviss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change and you will get the green check

ETHOS.md Outdated Show resolved Hide resolved
@alaviss alaviss force-pushed the shayanhabibi/codeofconduct branch from 9e2fd40 to 53ec42d Compare December 27, 2021 03:18
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@haxscramper haxscramper force-pushed the shayanhabibi/codeofconduct branch 2 times, most recently from 3accbed to 2d80a9f Compare December 27, 2021 18:14
Copy link
Contributor

@disruptek disruptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still pretty meh on this, but... meh.

readme.md Outdated
<!-- Join us on [matrix/irc][matrix-channel]! -->

Currently, this repository is our primary community hub; however, we'll introduce something more interactive as things grow. At this time our community is small but
Currently, this repository and our [matrix/irc][nim-works-matrix] are our primary community hubs; however, we'll introduce more as things grow. At this time our community is small but
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the however, is satisfied by the semi-colon

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Currently, this repository and our [matrix/irc][nim-works-matrix] are our primary community hubs; however, we'll introduce more as things grow. At this time our community is small but
Currently, this repository and our [matrix/irc][nim-works-matrix] are our primary community hubs; we'll introduce more as things grow. At this time our community is small but

ETHOS.md Outdated

### Scope

The code of ethics/ethos applies to all activities involving Nim-Works. It forms the basis for our code of conduct and decisions where we are otherwise not explicit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pick one; ethics or ethos -- do you really need both?

ETHOS.md Outdated
Comment on lines 49 to 56
1. We will not discriminate against any people(s); this includes discrimination by virtue of race, gender(s), sexuality, age, economic standing, education, or disability (physical or otherwise)
2. We will not knowingly try to harm any people(s) - physical or otherwise
3. We must endeavour to be open, transparent and honest
4. We believe in freedom of information
5. We believe in freedom of speech where it is not in conflict with any other ethos or value
6. We must be accountable for our actions
7. We will be impartial and independent of any other allegiance(s)
8. We believe that disagreement is a natural occurance; constructive criticism, and intellectual debate are welcomed; however, beligerant speech and aggression are neither
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add missing punctuation to these sentences.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. We will not discriminate against any people(s); this includes discrimination by virtue of race, gender(s), sexuality, age, economic standing, education, or disability (physical or otherwise)
2. We will not knowingly try to harm any people(s) - physical or otherwise
3. We must endeavour to be open, transparent and honest
4. We believe in freedom of information
5. We believe in freedom of speech where it is not in conflict with any other ethos or value
6. We must be accountable for our actions
7. We will be impartial and independent of any other allegiance(s)
8. We believe that disagreement is a natural occurance; constructive criticism, and intellectual debate are welcomed; however, beligerant speech and aggression are neither
1. We will not discriminate against any people(s); this includes discrimination by virtue of race, gender(s), sexuality, age, economic standing, education, or disability (physical or otherwise).
2. We will not knowingly try to harm any people(s) - physical or otherwise.
3. We must endeavour to be open, transparent and honest.
4. We believe in freedom of information.
5. We believe in freedom of speech where it is not in conflict with any other ethos or value.
6. We must be accountable for our actions.
7. We will be impartial and independent of any other allegiance(s).
8. We believe that disagreement is a natural occurance; constructive criticism, and intellectual debate are welcomed; however, beligerant speech and aggression are neither.

Copy link
Collaborator

@saem saem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left suggestions so they're easy commit and squash.

ETHOS.md Outdated
Comment on lines 49 to 56
1. We will not discriminate against any people(s); this includes discrimination by virtue of race, gender(s), sexuality, age, economic standing, education, or disability (physical or otherwise)
2. We will not knowingly try to harm any people(s) - physical or otherwise
3. We must endeavour to be open, transparent and honest
4. We believe in freedom of information
5. We believe in freedom of speech where it is not in conflict with any other ethos or value
6. We must be accountable for our actions
7. We will be impartial and independent of any other allegiance(s)
8. We believe that disagreement is a natural occurance; constructive criticism, and intellectual debate are welcomed; however, beligerant speech and aggression are neither
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. We will not discriminate against any people(s); this includes discrimination by virtue of race, gender(s), sexuality, age, economic standing, education, or disability (physical or otherwise)
2. We will not knowingly try to harm any people(s) - physical or otherwise
3. We must endeavour to be open, transparent and honest
4. We believe in freedom of information
5. We believe in freedom of speech where it is not in conflict with any other ethos or value
6. We must be accountable for our actions
7. We will be impartial and independent of any other allegiance(s)
8. We believe that disagreement is a natural occurance; constructive criticism, and intellectual debate are welcomed; however, beligerant speech and aggression are neither
1. We will not discriminate against any people(s); this includes discrimination by virtue of race, gender(s), sexuality, age, economic standing, education, or disability (physical or otherwise).
2. We will not knowingly try to harm any people(s) - physical or otherwise.
3. We must endeavour to be open, transparent and honest.
4. We believe in freedom of information.
5. We believe in freedom of speech where it is not in conflict with any other ethos or value.
6. We must be accountable for our actions.
7. We will be impartial and independent of any other allegiance(s).
8. We believe that disagreement is a natural occurance; constructive criticism, and intellectual debate are welcomed; however, beligerant speech and aggression are neither.

ETHOS.md Outdated Show resolved Hide resolved
readme.md Outdated
<!-- Join us on [matrix/irc][matrix-channel]! -->

Currently, this repository is our primary community hub; however, we'll introduce something more interactive as things grow. At this time our community is small but
Currently, this repository and our [matrix/irc][nim-works-matrix] are our primary community hubs; however, we'll introduce more as things grow. At this time our community is small but
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Currently, this repository and our [matrix/irc][nim-works-matrix] are our primary community hubs; however, we'll introduce more as things grow. At this time our community is small but
Currently, this repository and our [matrix/irc][nim-works-matrix] are our primary community hubs; we'll introduce more as things grow. At this time our community is small but

… sectionadd matrix link and badge@Vindaar corrections with ETHOSsome initial editsupdate dor to be internationally recognisedChanges as per @saem and @alaviss
@haxscramper haxscramper force-pushed the shayanhabibi/codeofconduct branch from 2d80a9f to 7d335da Compare December 27, 2021 18:49
@haxscramper
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 27, 2021

Build succeeded:

@bors bors bot merged commit 9f19557 into devel Dec 27, 2021
@bors bors bot deleted the shayanhabibi/codeofconduct branch December 27, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants