Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#425] As a developer, I would like to have KIF setup when I start a new project #426

Merged
merged 3 commits into from
Mar 31, 2023

Conversation

blyscuit
Copy link
Collaborator

@blyscuit blyscuit commented Jan 10, 2023

What happened

Add KIF and KIF target to the template.

Insight

  • Add KIF to the template.
  • Add a new Unit Test target for running KIF.
  • Add KIF boilerplate for Swift.
  • Add a demo KIF test so that KIF is correctly running in our Test workflow.
  • Add KIF scheme to override default. So that it does not appear in scheme selection.
  • Add Wiki for KIF.

Proof Of Work

Screen Shot 2023-01-10 at 09 59 12

@blyscuit blyscuit self-assigned this Jan 10, 2023
@blyscuit blyscuit added this to the 4.1.0 milestone Jan 10, 2023
@blyscuit blyscuit force-pushed the feature/#425-KIF branch 2 times, most recently from 670881d to 08c9702 Compare January 10, 2023 05:37
@blyscuit blyscuit changed the title [#425] Add KIF [#425] As a developer, I would like to have KIF setup when I start a new project Jan 10, 2023
@blyscuit blyscuit marked this pull request as ready for review January 10, 2023 06:56
@ducbm051291
Copy link
Contributor

Correct me if I'm wrong, but should the base branch be develop?

@blyscuit blyscuit changed the base branch from main to develop January 10, 2023 10:45
Copy link
Contributor

@markgravity markgravity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@vnntsu
Copy link
Contributor

vnntsu commented Jan 31, 2023

@blyscuit Could you check @Shayokh144's comment? It would be nice if we could merge this PR today for the release 🫶

@blyscuit
Copy link
Collaborator Author

@vnntsu I might not have time to update this PR this week. There is also issue with Quick6 that causes UI to not update. I would like to clear things with Quick6 first. Could we move this to next milestone 🙏 .

@suho
Copy link
Member

suho commented Jan 31, 2023

@blyscuit When having a KIFUITests target, should we consider removing the UITests target (XCTest)?

@blyscuit
Copy link
Collaborator Author

@blyscuit When having a KIFUITests target, should we consider removing the UITests target (XCTest)?

Agree, since recreating UITests target takes tiny fraction of time.

@vnntsu vnntsu removed this from the 4.1.0 milestone Jan 31, 2023
@vnntsu vnntsu added this to the 4.2.0 milestone Jan 31, 2023
@blyscuit
Copy link
Collaborator Author

blyscuit commented Feb 1, 2023

Converting to draft until solving issue with Quick6

@blyscuit blyscuit marked this pull request as draft February 1, 2023 02:25
@vnntsu vnntsu modified the milestones: 4.2.0, 4.3.0 Feb 28, 2023
@blyscuit blyscuit marked this pull request as ready for review March 31, 2023 07:34
@blyscuit
Copy link
Collaborator Author

@vnntsu This PR is now ready to review and merge. The issue with Quick6 can be mitigate with wait or with

    func tapView(withAccessibilityLabel accessibilityLabel: String) async {
        return await withCheckedContinuation { continuation in
            DispatchQueue.main.async {
                self.kitTestActor.tapView(withAccessibilityLabel: accessibilityLabel)
                continuation.resume()
            }
        }
    }

I tried the wait approach in a current project and it works fine 👍

@vnntsu vnntsu added this pull request to the merge queue Mar 31, 2023
Merged via the queue into develop with commit 2833cca Mar 31, 2023
@vnntsu vnntsu deleted the feature/#425-KIF branch March 31, 2023 09:21
@vnntsu vnntsu mentioned this pull request Mar 31, 2023
vnntsu added a commit that referenced this pull request Apr 11, 2023
…st-workflows-using-close-#-notion

[#426] Remove duplicate in PULL REQUEST TEMPLATE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a developer, I would like to have KIF setup when I start a new project
7 participants