Skip to content

Commit

Permalink
[#422] Change to use @nimblehq/eslint-config-nimble-core (#507)
Browse files Browse the repository at this point in the history
* [#422] Change to use `eslint-config-nimble-core`

* Update eslint core package version

* Use `eslint.config.mjs` instead of oudated `.eslintignore`

* Use `ignores` key instead
  • Loading branch information
sanG-github authored Apr 11, 2024
1 parent e1afdc2 commit cbf999c
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .template/addons/openapi/package.json.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
end

run 'yarn add --dev eslint'
run 'yarn add --dev @nimblehq/eslint-config-nimble@2.2.1'
run 'yarn add --dev @nimblehq/eslint-config-nimble-core@2.8.1'
run 'yarn add --dev @apidevtools/swagger-cli@4.0'
run 'yarn add --dev @stoplight/spectral-cli@6.8'
run 'yarn add --dev eslint-plugin-yml@1.8'
Expand Down
2 changes: 1 addition & 1 deletion .template/spec/addons/base/openapi/template_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
file_content = JSON.parse(file('package.json').content)['devDependencies']

expect(file_content).to include('eslint')
expect(file_content).to include('@nimblehq/eslint-config-nimble')
expect(file_content).to include('@nimblehq/eslint-config-nimble-core')
expect(file_content).to include('@apidevtools/swagger-cli')
expect(file_content).to include('@stoplight/spectral-cli')
expect(file_content).to include('eslint-plugin-yml')
Expand Down
2 changes: 1 addition & 1 deletion .template/spec/variants/web/package_json_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@

describe 'Development Dependencies' do
it 'adds Nimble eslint config dependency' do
expect(subject['devDependencies']).to include('@nimblehq/eslint-config-nimble')
expect(subject['devDependencies']).to include('@nimblehq/eslint-config-nimble-core')
end

it 'adds stylelint dependencies' do
Expand Down
4 changes: 2 additions & 2 deletions .template/variants/web/.eslintrc.tt
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"extends": [
<%- if @install_openapi -%>
"@nimblehq/eslint-config-nimble",
"@nimblehq/eslint-config-nimble-core",
"plugin:yml/recommended"
<%- else -%>
"@nimblehq/eslint-config-nimble"
"@nimblehq/eslint-config-nimble-core"
<%- end -%>
],
"globals": {
Expand Down
2 changes: 1 addition & 1 deletion .template/variants/web/package.json.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

run 'yarn add --dev eslint'
run 'yarn add --dev stylelint@^15'
run 'yarn add --dev @nimblehq/eslint-config-nimble@2.2.1'
run 'yarn add --dev @nimblehq/eslint-config-nimble-core@2.8.1'
run 'yarn add --dev @nimblehq/stylelint-config-nimble@1.1.0'

# Setup scripts
Expand Down

0 comments on commit cbf999c

Please sign in to comment.