Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#417] Revise the config to generate the project for --api accordingly #455

Merged
merged 5 commits into from
Sep 26, 2023
Merged

[#417] Revise the config to generate the project for --api accordingly #455

merged 5 commits into from
Sep 26, 2023

Conversation

sanG-github
Copy link
Contributor

@sanG-github sanG-github commented Aug 4, 2023 •
edited
Loading

close #417

What happened 👀

Improve the project generated by the template with the --api option, which is API application only.

Note

Due to the need for OpenAPI specs from node later, we no longer need to remove it.

Insight 📝

  • Removed all redundant parts as mentioned in the issue, thanks to @hoangnguyen92dn.
  • Also change the deprecated option when running rubocop.

Proof Of Work 📹

Option before Option after
Screenshot 2023-08-04 at 14 29 53 Screenshot 2023-08-04 at 14 32 55

@sanG-github sanG-github self-assigned this Aug 4, 2023
@sanG-github sanG-github added this to the 5.8.0 milestone Aug 4, 2023
@sanG-github sanG-github marked this pull request as ready for review August 18, 2023 04:27
@suho
Copy link
Member

suho commented Aug 28, 2023

@sanG-github After adding OpenAPI and its tools to the rails templates (#446), you will need Node for both variants. Thus, I suggest marking this pull request as a draft PR and working on this later.

@sanG-github sanG-github marked this pull request as draft August 31, 2023 04:54
@malparty malparty modified the milestones: 5.8.0, 5.9.0 Sep 14, 2023
@sanG-github sanG-github force-pushed the feature/gh417-improve-api-app-generation branch from 3e762bb to a9f84ba Compare September 18, 2023 07:37
@sanG-github sanG-github marked this pull request as ready for review September 18, 2023 07:39
@sanG-github sanG-github force-pushed the feature/gh417-improve-api-app-generation branch from a9f84ba to 6b4429b Compare September 21, 2023 04:31
olivierobert
olivierobert approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@olivierobert olivierobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@malparty malparty added this pull request to the merge queue Sep 26, 2023
Merged via the queue into develop with commit 2ff76f1 Sep 26, 2023
5 checks passed
@malparty malparty deleted the feature/gh417-improve-api-app-generation branch September 26, 2023 04:00
@malparty malparty mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malparty malparty malparty approved these changes

@olivierobert olivierobert olivierobert approved these changes

@rosle rosle Awaiting requested review from rosle

@andyduong1920 andyduong1920 Awaiting requested review from andyduong1920 andyduong1920 is a code owner

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@carryall carryall Awaiting requested review from carryall carryall is a code owner

@hoangmirs hoangmirs Awaiting requested review from hoangmirs hoangmirs is a code owner

@longnd longnd Awaiting requested review from longnd longnd is a code owner

@tyrro tyrro Awaiting requested review from tyrro

Assignees

@sanG-github sanG-github

Labels
type : bug
Projects
None yet
Milestone
5.9.0
Development

Successfully merging this pull request may close these issues.

Revise the config to generate the project for --api accordingly
4 participants
@sanG-github @suho @olivierobert @malparty