[#357] Fix: docker compose command is not working as expected

[sanG-github]

• Close Fix: docker compose command is not working as expected #357

What happened 👀

Update the docker-compose from v1 to docker compose v2. 🚀

Update the APP_NAME to use hyphen instead of underscore when it comes to container_name.

Insight 📝

When changing the docker-compose from version 1 to version 2, the gist is that they keep the container name to be a valid name for DNS hostnames with hyphen (-) as a separator instead of underscore (_) as before. (ref)

Note

With the APP_NAME = rails_template

For the current codebase, we previously used underscore for all the container names primarily, such as:

• rails_template_test_run_9ae09012e3d0
• rails_template_redis

But after changing docker-compose to a newer version without any additional modifications, those container names become:

• rails_template-test-run-9ae09012e3d0
• rails_template-redis

-> So we need to update all container names to be consistent with that convention, using only hyphen.

Caution

We previously tried to find the test run container by the name, but it was used with underscore -> challenge when switching to use hyphen as it keeps raising the container name not found.

I tried to log some information when the test flow was running, but it looked weird.

In this workflow run, the log returns a list of the container name and ID respectively. And we can get the ID from the container name as show below:

But after changing it to hyphen, with the same approach, we cannot retrieve that container ID in this workflow run.

Proof Of Work 📹

Built and renamed the docker image successfully

[malparty]

Just not sure about the last usage of APP_NAME 👀

[khangbui22]

LGTM 🚀