Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warning, clean up nimiq-time crate and use it everywhere #3165

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

hrxi
Copy link
Contributor

@hrxi hrxi commented Nov 28, 2024

  • Make sure to only export API supported on all platforms.
  • Make sure not to leak implementation details.
  • All return values are named types now.
  • Also make sure we continue to use nimiq-time everywhere.

@hrxi hrxi force-pushed the hrxi/minor_fixes77 branch from ae9c711 to dcf4a16 Compare November 28, 2024 17:36
hrxi added 2 commits November 28, 2024 18:38
- Make sure to only export API supported on all platforms.
- Make sure not to leak implementation details.
- All return values are named types now.
Also make sure we continue to do so.
@hrxi hrxi force-pushed the hrxi/minor_fixes77 branch from dcf4a16 to 3d4bd1b Compare November 28, 2024 17:38
@hrxi hrxi changed the title Clean up nimiq-time crate and use it everywhere Fix clippy warning, clean up nimiq-time crate and use it everywhere Nov 28, 2024
Copy link
Member

@jsdanielh jsdanielh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsdanielh jsdanielh merged commit 8117984 into albatross Dec 4, 2024
8 checks passed
@jsdanielh jsdanielh deleted the hrxi/minor_fixes77 branch December 4, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants