Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align example config path with docs #3184

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

riptl
Copy link
Contributor

@riptl riptl commented Dec 7, 2024

What's in this pull request?

The Dockerfile and README create the example config at client.example.toml.
Running nimiq-client creates client.toml.example.

I picked client.example.toml.

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

@riptl
Copy link
Contributor Author

riptl commented Dec 7, 2024

Also, (a slightly late) congrats on the PoS mainnet release. You've all done a fantastic job 🎉

Copy link
Member

@Eligioo Eligioo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree on that it should end with the .toml extension.

My only concern is how much we should consider this 'breaking'. If somebody would have some kind of automated build/deploy script, it could make stuff kaputt.

Copy link
Member

@jsdanielh jsdanielh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsdanielh jsdanielh merged commit 0bf895d into nimiq:albatross Dec 13, 2024
7 checks passed
@riptl riptl deleted the patch-1 branch December 15, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants