feat: added crc support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
requested changes
Jun 4, 2024
OasisApi.ts
Outdated
Comment on lines
371
to
374
| case OasisAsset.CRC: | ||
| decimals = 2; break; |
There was a problem hiding this comment.
Are we going to handle CRC with 2 decimals? AFAIK decimals in CRC are no longer used. Does Fastspot or OASIS ever use decimals for CRC?
There was a problem hiding this comment.
We won't use decimals, but in the UI we might add two decimals with 2 zeros like 5700.00
There was a problem hiding this comment.
Just know that this means that the library will return 500 CRC as 50000, as it converts what the API gives to the smallest unit, and you are specifying here that the smallest unit is 2 decimals lower than the decimal dot.
sisou
reviewed
Jun 18, 2024
|
|
||
| script:post-response { | ||
| let data = res.getBody(); | ||
| bru.setEnvVar("htlc_id",data.id); |
There was a problem hiding this comment.
Oh, super cool, didn't know this is possible! 👍👍👍
sisou
approved these changes
Jun 18, 2024
sisou
approved these changes
Jul 26, 2024
Also added support for smsApiToken in the `/settle` request
Also added post scripts to request to automatically update env variables after each call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added support for smsApiToken in the
/settlerequest