Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nimiq button: small, big, arrow, back #91

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

svub
Copy link
Member

@svub svub commented Jul 26, 2020

Turning buttons used on the website into a reusable component. Using Nimiq Style to make button small and big, with or without an arrow, and also as back button (arrow on the left pointing left)

@svub svub requested review from danimoh and sisou July 26, 2020 19:32
Copy link
Member

@sisou sisou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Background transition seems to be missing in small case.

The Wallet now also includes a blue button without arrow that is a medium size. If this component can cover that, that would be great.

Furthermore, I would simply name this component Button.

@svub
Copy link
Member Author

svub commented Jul 27, 2020

Can you share a pointer where to find that medium sized button? :)

@svub
Copy link
Member Author

svub commented Jul 27, 2020

Ok, checked, seems Button is not possible - or at least not recommended.
https://vuejs.org/v2/style-guide/#Multi-word-component-names-essential

So far it's NimiqButton it could also be StyledButton. Wdyt?

@svub
Copy link
Member Author

svub commented Jul 27, 2020

Background transition seems to be missing in small case.

Checking https://nimiq.github.io/nimiq-style/demo.html#pill-buttons - pill buttons don't have a background animation.

@sisou
Copy link
Member

sisou commented Jul 27, 2020

The medium size is used in the Wallet for the Send and Receive buttons: https://github.com/nimiq/wallet/blob/master/src/components/MobileActionBar.vue#L48

The pill buttons don't have an animation at the moment because no pseudo Element was left to be used for it. Now with a proper component, those buttons should also transition their background. Julian requested that a couple of times.

OK, then the button can be called NimiqButton or StyledButton or NQButton.

@danimoh danimoh force-pushed the master branch 2 times, most recently from 2b462fb to e64b89b Compare July 8, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants