-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nimiq button: small, big, arrow, back #91
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Background transition seems to be missing in small case.
The Wallet now also includes a blue button without arrow that is a medium size. If this component can cover that, that would be great.
Furthermore, I would simply name this component Button
.
Can you share a pointer where to find that medium sized button? :) |
Ok, checked, seems Button is not possible - or at least not recommended. So far it's |
Checking https://nimiq.github.io/nimiq-style/demo.html#pill-buttons - pill buttons don't have a background animation. |
The medium size is used in the Wallet for the Send and Receive buttons: https://github.com/nimiq/wallet/blob/master/src/components/MobileActionBar.vue#L48 The pill buttons don't have an animation at the moment because no pseudo Element was left to be used for it. Now with a proper component, those buttons should also transition their background. Julian requested that a couple of times. OK, then the button can be called NimiqButton or StyledButton or NQButton. |
2b462fb
to
e64b89b
Compare
Turning buttons used on the website into a reusable component. Using Nimiq Style to make button small and big, with or without an arrow, and also as back button (arrow on the left pointing left)