Remove most packages #1011
Merged
Remove most packages #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most users surely have upgraded Erlang.mk since then.
The tests were waiting for the test group to finish before they could continue with the next test group. Now "core" and "all" targets directly depend on individual test cases, allowing parallel Make to get to the next tests quicker and removing 1/3rd of the total run time. make check -j8 -k 5790,16s user 1207,08s system 627% cpu 18:35,49 total make check -j8 -k 6250,13s user 1326,77s system 972% cpu 12:59,16 total
Erlang.mk will no longer feature packages out of the box, except for the applications that we implement plugins for (such as erlydtl, proper or relx) and the projects I work on that are also used to test Erlang.mk (cowboy and friends). This is a breaking change. In most cases the fix is to add a full dep_* line for the dependencies that were used as packages before.
essen
force-pushed
the
remove-most-packages
branch
3 times, most recently
from
99eb686
to
84e2a66
Compare
essen
force-pushed
the
remove-most-packages
branch
from
84e2a66
to
66e970f
Compare
essen
force-pushed
the
remove-most-packages
branch
from
187ada3
to
33f1ff9
Compare
essen
force-pushed
the
remove-most-packages
branch
2 times, most recently
from
2d83264
to
ebe6a6f
Compare
This should both be more solid and more secure.
Use the query_* equivalents instead.
This method dates back from the beginnings of Erlang.mk and should not have been used for around a decade by now. Adding "git" to the offending dep lines is enough to upgrade.
We use $1 instead of $(1) or $p instead of $(p) when possible, except when building variable names (pkg_$(p)_name for example, but also $(dep_fetch_$(1))).
essen
force-pushed
the
remove-most-packages
branch
from
fcfd790
to
e507a7c
Compare
This includes the SSL security fix for OTP-25+.
|
Merged!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.