Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed library location for Python 3.10. #375

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

notiska
Copy link
Contributor

@notiska notiska commented Feb 9, 2022

When checking for the Python library path, the pattern would not match more than one number.
This means that jep would not be able to find the shared library for Python 3.10 installations.

@notiska notiska changed the base branch from master to dev_4.0 February 9, 2022 18:25
Copy link
Member

@bsteffensmeier bsteffensmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

I think this change is minor enough to go in a 4.0.2 release, @ndjensen do you agree?

Copy link
Member

@ndjensen ndjensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that this would be good in 4.0.2. Thanks for the fix!

@bsteffensmeier bsteffensmeier merged commit efde9b5 into ninia:dev_4.0 Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants