Change Java fields and methods to type attributes instead of instance attributes #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… attributes. The relationship between PyJObjects and their types now more closely resembles the behavior of normal Python types, allowing special methods such as __add__ and __repr__ to be picked up by Python when they are defined in Java classes. Since all attributes of PyJObject have moved to the type the attr dict is no longer necessary. However, every instance of PyJClass still shares a type so it is not possible to move attributes of PyJClass to the type. Much of the code for dealing with instance attributes has moved from PyJObject to PyJClass.
Closed
ndjensen
reviewed
Mar 29, 2022
ndjensen
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relationship between PyJObjects and their types now more closely resembles
the behavior of normal Python types, allowing special methods such as add
and repr to be picked up by Python when they are defined in Java classes.
Since all attributes of PyJObject have moved to the type the attr dict is no
longer necessary. However, every instance of PyJClass still shares a type so it
is not possible to move attributes of PyJClass to the type. Much of the code
for dealing with instance attributes has moved from PyJObject to PyJClass.