Auto detect JAVA_HOME on Linux #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My black formatter seemed to make some unnecessary changes. |
ndjensen
reviewed
Jul 29, 2024
Makefile
Outdated
| $(PYTHON) $(SETUP) uninstall | ||
|
|
||
| .PHONY: all build clean install uninstall | ||
|
|
There was a problem hiding this comment.
I'd prefer if we didn't include the Makefile as I don't think @bsteffensmeier or myself will ever test or maintain it to make sure it still works. Also I believe with newer versions of setuptools we're no longer supposed to call python setup.py target and this is one more thing we'd have to maintain as we shift away from that.
bsteffensmeier
approved these changes
Jul 31, 2024
ndjensen
requested changes
Jul 31, 2024
|
Thanks Nate. |
ndjensen
approved these changes
Aug 3, 2024
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By tracking the link to javac we can find the actual path and set it to JAVA_HOME.