Update threading checks to be compatible with Python 3.13 #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.13 is changing the way threading.active_count() works in sub-interpreters. In previous versions when no other threads in the interpreter are active then there is only 1 active thread. New in Python 3.13 the main thread if the main interpreter is included in the
active_count()of sub-interpreters so there will always be 2 active threads. Since we check for active threads before ending the interpreter those checks are being updated for compatibility. The changes to Python that made this change necessary were made under python/cpython#114271. This problem was discovered in Python 3.13rc1 and the change has been verified in that version.