Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Python garbage collector when an interpreter is closed. #556

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Run Python garbage collector when an interpreter is closed. #556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/c/Jep/pyembed.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ void pyembed_thread_close(JNIEnv *env, intptr_t _jepThread)
Py_DECREF(key);

Py_CLEAR(jepThread->globals);
PyGC_Collect();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why do you the gc collect call before the Py_EndInterpreter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not specifically documented for PyGC_Collect but my default assumption for any Python c-api call is that it requires the thread to have an interpreter or at least hold the GIL and after Py_EndInterpreter the thread has neither.


if (jepThread->classloader) {
(*env)->DeleteGlobalRef(env, jepThread->classloader);
Expand Down