Fix ClassList to handle jar in working dir with classpath in manifest. #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndjensen
approved these changes
Dec 5, 2024
|
This is the same area of code as mentioned in #323. Based on the comment from June 1st, 2021, I think it also fixes that issue. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #576 which would come up if your class path includes a jar in the current working directory that has a class path in the manifest. The manifest processing assumes every class path entry has a parent dir(lib/foo.jar) but if the jar is in the current working directory then class path entries may not have a parent dir(foo.jar).