Skip to content

Commit

Permalink
Allow 'ninja -t compdb' accept targets
Browse files Browse the repository at this point in the history
Test:
./ninja -t compdb --target wrong_target (fail)
./ninja -t compdb --target test_target (empty due to lack of rules)
./ninja -t compdb --target ninja,ninja_test cc cxx (ok)
./ninja -t compdb --target test_target cc cxx (ok)
./ninja -t compdb cxx (ok, regression test)
./ninja ninja_test && ./ninja_test (passed)

Co-authored-by: Linkun Chen <lkchen@google.com>
Co-authored-by: csmoe <csmoe@msn.com>
  • Loading branch information
2 people authored and pengtangjin committed Jan 28, 2024
1 parent 22b778c commit 3a0cf3c
Showing 1 changed file with 68 additions and 8 deletions.
76 changes: 68 additions & 8 deletions src/ninja.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sstream>
#include <set>
#include <assert.h>

#include <algorithm>
#include <cstdlib>
Expand Down Expand Up @@ -909,6 +912,32 @@ void printCompdb(const char* const directory, const Edge* const edge,
printf("\"\n }");
}

struct DependentEdgeCollector {
bool CollectFrom(Node* node, std::vector<Edge*>* depend_edges) {
assert(node);
assert(depend_edges);

if (!visited_nodes_.insert(node).second)
return true;

Edge* edge = node->in_edge();
if (!edge || !visited_edges_.insert(edge).second)
return true;

depend_edges->push_back(edge);

for (Node* input_node : edge->inputs_)
if (!CollectFrom(input_node, depend_edges))
return false;

return true;
}

private:
std::set<Node*> visited_nodes_;
std::set<Edge*> visited_edges_;
};

int NinjaMain::ToolCompilationDatabase(const Options* options, int argc,
char* argv[]) {
// The compdb tool uses getopt, and expects argv[0] to contain the name of
Expand All @@ -920,19 +949,51 @@ int NinjaMain::ToolCompilationDatabase(const Options* options, int argc,

optind = 1;
int opt;
while ((opt = getopt(argc, argv, const_cast<char*>("hx"))) != -1) {
const option long_options[] = {
{"target", required_argument, NULL, 't'},
{NULL, 0, NULL, 0}
};

std::vector<Edge*> edges_to_process = state_.edges_;
while ((opt = getopt_long(argc, argv, "x:", long_options, NULL)) != -1) {
switch(opt) {
case 'x':
eval_mode = ECM_EXPAND_RSPFILE;
break;

case 't': {
std::istringstream iss(optarg);
std::string target;
std::vector<Edge*> user_interested_edges;
DependentEdgeCollector deps_edge_collector;

while (std::getline(iss, target, ',')) {
string err;
Node* node = CollectTarget(target.c_str(), &err);

if (!node) {
Error("%s", err.c_str());
return 1;
}
if (!deps_edge_collector.CollectFrom(node, &user_interested_edges)) {
return 1;
}
}
if (user_interested_edges.size() > 0) {
edges_to_process = user_interested_edges;
}

break;
}

case 'h':
default:
printf(
"usage: ninja -t compdb [options] [rules]\n"
"\n"
"options:\n"
" -x expand @rspfile style response file invocations\n"
" -x expand @rspfile style response file invocations\n"
" --target TARGETS generate compilation database for given targets, separated by commas\n"
);
return 1;
}
Expand All @@ -955,23 +1016,22 @@ int NinjaMain::ToolCompilationDatabase(const Options* options, int argc,
}

putchar('[');
for (vector<Edge*>::iterator e = state_.edges_.begin();
e != state_.edges_.end(); ++e) {
if ((*e)->inputs_.empty())
for (Edge* e: edges_to_process) {
if (e->inputs_.empty())
continue;
if (argc == 0) {
if (!first) {
putchar(',');
}
printCompdb(&cwd[0], *e, eval_mode);
printCompdb(&cwd[0], e, eval_mode);
first = false;
} else {
for (int i = 0; i != argc; ++i) {
if ((*e)->rule_->name() == argv[i]) {
if (e->rule_->name() == argv[i]) {
if (!first) {
putchar(',');
}
printCompdb(&cwd[0], *e, eval_mode);
printCompdb(&cwd[0], e, eval_mode);
first = false;
}
}
Expand Down

0 comments on commit 3a0cf3c

Please sign in to comment.