Skip to content

Commit

Permalink
Merge pull request #2537 from zufuliu/msvc-utf-8
Browse files Browse the repository at this point in the history
Use `/utf-8` compiler option to fix MSVC C4819 warning.
  • Loading branch information
jhasse authored Dec 1, 2024
2 parents bf7cd9f + ba26f24 commit d79d8f7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -329,11 +329,12 @@ def search_system_path(file_name: str) -> Optional[str]: # type: ignore # Missi
raise Exception('cl.exe not found. Run again from the Developer Command Prompt for VS')
cflags = ['/showIncludes',
'/nologo', # Don't print startup banner.
'/utf-8',
'/Zi', # Create pdb with debug info.
'/W4', # Highest warning level.
'/WX', # Warnings as errors.
'/wd4530', '/wd4100', '/wd4706', '/wd4244',
'/wd4512', '/wd4800', '/wd4702', '/wd4819',
'/wd4512', '/wd4800', '/wd4702',
# Disable warnings about constant conditional expressions.
'/wd4127',
# Disable warnings about passing "this" during initialization.
Expand Down

0 comments on commit d79d8f7

Please sign in to comment.