Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect whether VC++ compiler can be found in configure.py #2086

Merged
merged 5 commits into from
Oct 23, 2022
Merged

Detect whether VC++ compiler can be found in configure.py #2086

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87b8965
Improve error messages when VS cannot be found
randomascii Jul 26, 2021
34d03bd
Merge branch 'ninja-build:master' into compiler_detect
randomascii Feb 17, 2022
3ef318c
Merge branch 'ninja-build:master' into compiler_detect
randomascii Feb 17, 2022
b5fa2d5
Fix function and parameter names, and comment
randomascii Mar 9, 2022
69fb2ce
Merge branch 'master' into compiler_detect
jhasse Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,9 +305,18 @@ def binary(name):
else:
n.variable('ar', configure_env.get('AR', 'ar'))

def search_system_path(file_name):
"""Find a file in the system path."""
for dir in os.environ['path'].split(';'):
path = os.path.join(dir, file_name)
if os.path.exists(path):
return path

# Note that build settings are separately specified in CMakeLists.txt and
# these lists should be kept in sync.
if platform.is_msvc():
if not search_system_path('cl.exe'):
raise Exception('cl.exe not found. Run again from the Developer Command Prompt for VS')
cflags = ['/showIncludes',
'/nologo', # Don't print startup banner.
'/Zi', # Create pdb with debug info.
Expand Down