Skip to content

Add ability not to use a smart terminal #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add ability not to use a smart terminal #2102

wants to merge 1 commit into from

Conversation

ken-matsui
Copy link
Contributor

@ken-matsui ken-matsui commented Mar 15, 2022

Ninja now can disable a smart terminal if users define the NINJA_NO_SMART_TERMINAL environmental variable in case users do not want to do overprinting.

Verified

This commit was signed with the committer’s verified signature.
ken-matsui Ken Matsui
@hadrielk
Copy link

hadrielk commented Jun 6, 2022

Can't you just set the environment variable TERM=dumb today, and not need this PR?

StatusPrinter's printer_ member is a LinePrinter, which checks for that environment variable in its constructor and makes smart_terminal_ false there, afaict.

@ken-matsui
Copy link
Contributor Author

@hadrielk
Thank you for your information. I will try it and close this PR if not needed :)

@ken-matsui
Copy link
Contributor Author

@hadrielk
Thank you, it worked! I am closing this PR ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants