Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building libninja-re2c.a on configure.py #2139

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Support building libninja-re2c.a on configure.py #2139

merged 1 commit into from
Aug 22, 2022

Conversation

ken-matsui
Copy link
Contributor

configure.py currently builds only libninja.a, but we also want the libninja-re2c.a like CMakeLists.txt does:

ninja/CMakeLists.txt

Lines 47 to 50 in 55f5451

add_library(libninja-re2c OBJECT ${PROJECT_BINARY_DIR}/depfile_parser.cc ${PROJECT_BINARY_DIR}/lexer.cc)
else()
message(WARNING "re2c was not found; changes to src/*.in.cc will not affect your build.")
add_library(libninja-re2c OBJECT src/depfile_parser.cc src/lexer.cc)

@jonesmz

This comment was marked as abuse.

@ken-matsui
Copy link
Contributor Author

Hi @jonesmz,

The configure.py is currently used in both Homebrew and MacPorts (and might other sources), so I would say deleting the script would bring a big breaking change.

Thus, if this breaking change is acceptable, I think the script should be removed and I am more in favor of that.

@hadrielk
Copy link

hadrielk commented Jun 10, 2022

Fedora and others use it too, in their RPM specs.

@ken-matsui
Copy link
Contributor Author

Ah, then this PR should have the least impact, IMO.

@jonesmz

This comment was marked as abuse.

@ken-matsui
Copy link
Contributor Author

Yes, ideally, it would be great, and I would agree with you if I were a maintainer without historical background knowledge. Could you please open a PR that removes configure.py rather than updating this PR? Either yours or mine will be merged by maintainers.

@jonesmz

This comment was marked as abuse.

@jhasse jhasse merged commit 864f7b5 into ninja-build:master Aug 22, 2022
@ken-matsui ken-matsui deleted the support-building-libninja-re2c-on-configure-py branch August 22, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants