Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #2494

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix typos #2494

merged 1 commit into from
Sep 19, 2024

Conversation

spaette
Copy link
Contributor

@spaette spaette commented Sep 6, 2024

opened as a Draft as netherless might be replaced with another string

$ sed -n '3264p' ninja/src/build_test.cc
  // Validate that out is rebuilt netherless, as deps are missing.
$ 

@spaette
Copy link
Contributor Author

spaette commented Sep 6, 2024

@digit-google

replaced with another string

Would that be nonetheless or nevertheless?

My sympathies are with using nevertheless as the replacement string.

@digit-google
Copy link
Contributor

Thanks, this looks good to me. I think we should go with nevertheless, from definitions I am finding online. @jhasse any idea here?

@jhasse jhasse marked this pull request as ready for review September 9, 2024 13:56
@spaette
Copy link
Contributor Author

spaette commented Sep 9, 2024

@digit-google

used nevertheless
made a soft reset
workflow may need to be approved again

@mcprat
Copy link
Contributor

mcprat commented Sep 9, 2024

consider regardless

@spaette
Copy link
Contributor Author

spaette commented Sep 10, 2024

regardless

that's understandable, but I've already replaced the string with nevertheless

@jhasse jhasse merged commit 6a31acc into ninja-build:master Sep 19, 2024
11 checks passed
@jhasse
Copy link
Collaborator

jhasse commented Sep 19, 2024

not a native speaker, but looks good to me. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants