"Fix" to Compile on OS X as well as "Waiting on" messages from todo list #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ended up merging fixes for the incbin problem. As for the "waiting on" message, I think it would be better to move it into BuildStatus, because it needs to be aware of the terminal capabilities. I think perhaps DoWork could return information about what it's still waiting for, and that could be passed to BuildStatus. Sorry for sitting on this merge request for so long; I had wanted to refactor this code, then did the refactor and forgot to notify you about it. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OS X fix is definitely temporary, but it gets ninja compiling on OS X.
For the Waiting on, I just poll with a timeout of 1 second, if there are no results I print the notice to stderr and then poll with no timeout.
To test for the waiting on, I just added "&& sleep 3" to the build script, which was pretty lazy, I know the correct thing to do was add a test to the tests file, but I was unsure how to pull out of stderr without doing something with nasty hard-to-fix side effects (dup2, for example). I figured I'd check to see if this was in the
neighborhood before going down that road further.