Two quick changes to make ninja compile on FreeBSD #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On FreeBSD backtrace() function is available in devel/libexecinfo port. |
|
'ar' command on FreeBSD 7.3 and bellow don't support 'T' flag. But I don't check 7.4-RC3 release yet. |
|
I have removed both the backtrace use and the T flag. Sorry for the delay, I wanted to think about both changes before committing to them. Thanks for the report! |
waynewangyuxuan
referenced
this pull request
in nyuoss/ninja-shadowdash-nyu
Oct 6, 2024
Update CI && README.md
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) the "T" flag for ar makes g++ complain about the format of that library and fail. I think it can be removed without problems.
b) the backtrace() function does not exist. It could be made conditional on some #define, but I'm not sure that's needed...