Merge pull request #346 from drieseng/unbound

Do not attempt to handle unbound generic type definition as collection.
ninject · Mar 5, 2019 · b23a959 · b23a959
2 parents 5763318 + f4f9609
commit b23a959
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/Ninject.Test/Integration/ReadOnlyKernelTests.cs b/src/Ninject.Test/Integration/ReadOnlyKernelTests.cs
@@ -689,8 +689,7 @@ public void TryGet_ServiceAndConstraintAndParameters_ShouldPreferBindingForList(
                 bindings.Should().HaveCount(2);
             }
 
-
-            [Fact(Skip = "https://github.com/ninject/Ninject/issues/340")]
+            [Fact]
             public void TryGet_ServiceAndConstraintAndParameters_ReturnsNullWhenTypeIsUnboundGenericTypeDefinition()
             {
                 var service = typeof(List<>);
@@ -799,7 +798,7 @@ public void TryGet_ServiceAndConstraintAndParameters()
                 bindings.Should().BeEmpty();
             }
 
-            [Fact(Skip = "https://github.com/ninject/Ninject/issues/340")]
+            [Fact]
             public void TryGet_ServiceAndConstraintAndParameters_ReturnsNullWhenTypeIsUnboundGenericTypeDefinition()
             {
                 var service = typeof(List<>);

diff --git a/src/Ninject/ReadOnlyKernel.cs b/src/Ninject/ReadOnlyKernel.cs
@@ -492,7 +492,7 @@ void UpdateRequest(Type service)
                 return this.ResolveAll(request, false).CastSlow(service).ToArraySlow(service);
             }
 
-            if (request.Service.IsGenericType)
+            if (request.Service.IsGenericType && !request.Service.IsGenericTypeDefinition)
             {
                 var gtd = request.Service.GetGenericTypeDefinition();