Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect code in Selector.cs #217

Closed
oznetmaster opened this issue Sep 13, 2016 · 0 comments
Closed

Incorrect code in Selector.cs #217

oznetmaster opened this issue Sep 13, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@oznetmaster
Copy link

            if (this.Settings.InjectParentPrivateProperties)
            {
                for (Type parentType = type.GetTypeInfo().BaseType; parentType != null; parentType = parentType.GetTypeInfo().BaseType)
                {
                    properties.AddRange(this.GetPrivateProperties(type.GetTypeInfo().BaseType));
                }
            }

Note that this does the same thing over and over. It seems that it should be:

            if (this.Settings.InjectParentPrivateProperties)
            {
                for (Type parentType = type.GetTypeInfo().BaseType; parentType != null; parentType = parentType.GetTypeInfo().BaseType)
                {
                    properties.AddRange(this.GetPrivateProperties(parentType));
                }
            }
@scott-xu scott-xu self-assigned this Sep 11, 2017
@scott-xu scott-xu added this to the 4.0 milestone Sep 11, 2017
scott-xu added a commit that referenced this issue Sep 11, 2017
@scott-xu scott-xu added the Bug label Sep 15, 2017
@scott-xu scott-xu modified the milestones: 4.0, 3.3.0 Sep 23, 2017
glenkeane-94 pushed a commit to glenkeane-94/Nin-ject that referenced this issue Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants