Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking if value is equal to DBNull in ParameterTarget to see if it has a DefaultValue is wrong on .NET Core #235

Closed
einari opened this issue Apr 12, 2017 · 1 comment
Closed

Checking if value is equal to DBNull in ParameterTarget to see if it has a DefaultValue is wrong on .NET Core #235

einari opened this issue Apr 12, 2017 · 1 comment
Assignees
@scott-xu
Labels
Bug
Milestone
3.3.0

Comments

@einari
Copy link

einari commented Apr 12, 2017

The HasDefaultValue implementation is not working correctly on .NET Core.
The DBNull.Value check will in fact return true when it in fact does not have a default value.

By flipping it from != to == - I got the right result, but not sure of the implications of that.
Equally, the ParameterInfo coming in does in fact have a property called HasDefaultValue - wouldn't it be better to use this instead? Or is there something that escapes me?
@einari einari mentioned this issue Apr 12, 2017
Closed
einari added a commit to dolittle/Bifrost that referenced this issue Apr 12, 2017
@einari
Work around for Ninject bug
324ee57 
Fixes #801

See ninject/Ninject#235 for more details
@scott-xu scott-xu added this to the 4.0 milestone Sep 15, 2017
@scott-xu scott-xu self-assigned this Sep 15, 2017
@scott-xu scott-xu added the Bug label Sep 15, 2017
@scott-xu
Copy link
Member

Fixed

@scott-xu scott-xu modified the milestones: 4.0, 3.3.0 Sep 23, 2017
glenkeane-94 pushed a commit to glenkeane-94/Nin-ject that referenced this issue Jun 17, 2022
@scott-xu
Fixed ninject/Ninject#235
fb29b63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scott-xu scott-xu

Labels
Bug
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
2 participants
@einari @scott-xu