ENH: Update image utility output path behaviour #81
Conversation
|
Best reviewed: commit by commit
Optimal code review plan (1 warning)
|
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
- Coverage 51.85% 51.54% -0.31%
==========================================
Files 20 21 +1
Lines 1186 1197 +11
Branches 151 155 +4
==========================================
+ Hits 615 617 +2
- Misses 564 573 +9
Partials 7 7
Continue to review full report at Codecov.
|
|
@oesteban should |
|
Hello @josephmje, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2020-03-17 19:25:53 UTC |
|
Warnings are found on analyzing the commit e962756. 1 warning:
We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure If you are struggling with these errors or warnings, feel free to ask us via chat. 💬 |
|
We might need to change the version of nipype that's pinned. The new version is getting |
|
Could you rebase? |
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
| self._results['out_b0s'] = rescale_b0( | ||
| self.inputs.in_file, | ||
| self.inputs.mask_file, | ||
| newpath=runtime.cwd | ||
| self.inputs.mask_file, out_b0s |
There was a problem hiding this comment.
I think this is what introduced #90 - the mask and the b0s are swapped.
There was a problem hiding this comment.
it failed at the very first step where the b0s get extracted. the difference between the 2 dwi images for that subject is that one contains multiple b0s and the borked contains a single b0. it looks like this single b0 case is messing things up.
There was a problem hiding this comment.
yup I realized after commenting. I'm still going through this - I might have found a solution.
No description provided.